Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace self by window #101

Closed
wants to merge 1 commit into from
Closed

Replace self by window #101

wants to merge 1 commit into from

Conversation

imsun
Copy link

@imsun imsun commented Aug 22, 2015

Solution for the problem in #100.

@zloirock
Copy link
Owner

See this table. It will break some environments.

@zloirock
Copy link
Owner

Possible add check window like self before self, but it requires additional tests.

zloirock added a commit that referenced this pull request Aug 22, 2015
@zloirock
check window before self for global detection, ~IE8 with changed …
2f62d27 
…`document.domain` case, close #100, #101
@zloirock zloirock closed this Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imsun @zloirock